jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r312723380
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##########
@@ -89,11 +91,11 @@ public R or(R leftResult, R rightResult) {
return null;
}
- public <T> R in(BoundReference<T> ref, Literal<T> lit) {
+ public <T> R in(BoundReference<T> ref, Set<Literal<T>> lits) {
return null;
Review comment:
Yeah, I agree.
Although I went through all concrete classes and fixed them (as I changed
the signature), it is better to throw exception instead of returning `null`.
It seems better to throw `UnsupportedOperationException` for default
implementations for all operations. I can make those changes if there is no
specific reason to `return null`.
Let me know your comments. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
