jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r312723407
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
##########
@@ -62,10 +95,10 @@ public String toString() {
return String.valueOf(ref()) + " == " + literal();
case NOT_EQ:
return String.valueOf(ref()) + " != " + literal();
-// case IN:
-// break;
-// case NOT_IN:
-// break;
+ case IN:
+ return String.valueOf(ref()) + " in " + literalSet();
Review comment:
Good point. Will update it accordingly. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
