manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522055383 @rdblue > This change would primarily just update getResultType and return DateType.get() when the granularity is ChronoUnit.DAYS. this is bit more clear now. thanks ! so this will change ( if granularity is Days) 1. ` Dates.getResultType ` ``` public Type getResultType(Type sourceType) { return Types.IntegerType.get(); } ``` and what about `Timestamps.getResultType` , does it also needs to return `Types.DateType.get()` , as that can also be needed to print datetime in metadata table. ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
