manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522798222 @rdblue quick questions. 1. while validating my changes, didn't see that transfor.getResultType is being used apart from `PartitionSpec.partitionType()`. can you point me to any other test-case or code path, where its being used can be verified. ( though Im adding test-cases to validate `Days.getResultType()` and `Timestamps.getResultType()`) 2. If we are returning DateType.get for Days why not for Month/Year as well. As for those types as well it will return Integer/day ordinal? 3. >That will cause the partition tuple's field type to be a date, which should also cause the metadata table to display formatted dates instead of the day ordinal in Spark. I believe metadata table referenced here is related to #252? Anything specific I need to test/validate if this change impacts the metadata tables?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
