rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314867459
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Binder.java
##########
@@ -140,6 +140,11 @@ public Expression or(Expression leftResult, Expression
rightResult) {
throw new IllegalStateException("Found already bound predicate: " +
pred);
}
+ @Override
+ public <T> Expression predicate(BoundSetPredicate<T> pred) {
Review comment:
Let's remove this method. Right now, all of the implementations of it are
identical to `predicate(BoundPredicate<T>)`. I'm not sure that we will need
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
