rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313970180
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -285,12 +284,12 @@ public Boolean or(Boolean leftResult, Boolean
rightResult) {
}
@Override
- public <T> Boolean in(BoundReference<T> ref, Literal<T> lit) {
+ public <T> Boolean in(BoundReference<T> ref, LiteralSet<T> literalSet) {
return ROWS_MIGHT_MATCH;
Review comment:
I think this should be implemented as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
