rdblue commented on a change in pull request #362: Support create and replace
transactions in Catalog
URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317371730
##########
File path:
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -66,6 +67,35 @@ public int currentVersion() {
return version;
}
+ @Override
+ public TableMetadata refresh() {
+ try {
+ doRefresh();
+ } catch (NoSuchTableException e) {
+ LOG.warn("Could not find the table during refresh, setting current
metadata to null", e);
+ currentMetadata = null;
+ currentMetadataLocation = null;
+ version = -1;
+ shouldRefresh = false;
+ throw e;
+ }
+ return current();
+ }
+
+ protected void doRefresh() {
+ throw new UnsupportedOperationException("Not implemented: doRefresh");
+ }
+
+ @Override
+ public void commit(TableMetadata base, TableMetadata metadata) {
+ doCommit(base, metadata);
+ requestRefresh();
Review comment:
Being able to ensure this is called is an unexpected benefit!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
