rdblue commented on a change in pull request #362: Support create and replace
transactions in Catalog
URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317371809
##########
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##########
@@ -241,7 +234,14 @@ private void commitCreateTransaction() {
}
}
- private void commitReplaceTransaction() {
+ private void commitReplaceTransaction(boolean orCreate) {
+ if (base == null && !orCreate) {
+ throw new NoSuchTableException("Table doesn't exist");
Review comment:
Since this isn't called inside the commit retry loop, it will always depend
on the initial state of the transaction, right? In that case, the problem
should be caught when the transaction is created instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
