rdblue commented on a change in pull request #421: Add friendly names to
catalog tables
URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r318662709
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -43,6 +43,11 @@ public HiveCatalog(Configuration conf) {
this.conf = conf;
}
+ @Override
+ protected String name() {
+ return conf.get("hive.metastore.uris");
Review comment:
Yeah, if there are multiple URIs it will look strange. The problem is that
we don't have a name for the catalog. I guess we could update the constructor
to pass one in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
