rdblue commented on a change in pull request #421: Add friendly names to
catalog tables
URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r349349827
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -236,4 +243,27 @@ private static void deleteFiles(FileIO io,
Set<ManifestFile> allManifests) {
}
});
}
+
+ private static String fullTableName(String catalogName, TableIdentifier
identifier) {
+ StringBuilder sb = new StringBuilder();
+
+ if (catalogName.contains("/") || catalogName.contains(":")) {
Review comment:
Yes, I think we do. Other catalogs that extend `BaseMetastoreCatalog` may
choose to use a URI for catalog name like the original PR. I think that's a
reasonable format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
