rdblue commented on a change in pull request #432: Allow writers to control
size of files generated
URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r319704128
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -102,6 +101,7 @@
this.replacePartitions = replacePartitions;
this.applicationId = applicationId;
this.wapId = wapId;
+ this.targetFileSize = options.getLong("target-file-size", Long.MAX_VALUE);
Review comment:
Do you intend to make this a table property as well? I think it makes sense
as table configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
