rdblue commented on a change in pull request #432: Allow writers to control 
size of files generated
URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321015709
 
 

 ##########
 File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java
 ##########
 @@ -303,66 +305,128 @@ public String toString() {
         }
       }
     }
+
+    private class EncryptedOutputFileFactory implements 
OutputFileFactory<EncryptedOutputFile> {
 
 Review comment:
   Should this be merged with `AppenderFactory`? That could provide 
`newAppender(PartitionKey, FileFormat)` and `newAppender(FileFormat)` instead 
of accepting an `OutputFile`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to