xabriel commented on a change in pull request #452: V1 Vectorized Reader for
Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/452#discussion_r321348369
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -67,8 +75,27 @@ public DataSourceReader createReader(DataSourceOptions
options) {
Configuration conf = new Configuration(lazyBaseConf());
Table table = getTableAndResolveHadoopConfiguration(options, conf);
String caseSensitive =
lazySparkSession().conf().get("spark.sql.caseSensitive", "true");
+ String sparkMaster = lazySparkSession().conf().get("spark.master");
+ SparkConf sparkConf = lazySparkSession().sparkContext().conf();
Review comment:
Doesn't seem like we're using `sparkMaster` nor `sparkConf` anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
