aokolnychyi commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333245244
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -595,6 +595,9 @@ private Evaluator
extractInclusiveDeleteExpression(ManifestReader reader) {
if (bin.contains(cachedNewManifest) && bin.size() <
minManifestsCountToMerge) {
// not enough to merge, add all manifest files to the output list
outputManifests.addAll(bin);
+ } else if (bin.size() < minManifestsCountToMerge) {
Review comment:
I think this changes the way `mergeGroup` works and might lead to never
merging certain old manifests.
I would try to modify the if condition above (i.e.
`bin.contains(cachedNewManifest)`) to check if the bin contains anything from
appendManifests. Having said that, I am not sure about the performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
