aokolnychyi commented on a change in pull request #524: respect commit.manifest.min.count URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333245819
########## File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java ########## @@ -595,6 +595,9 @@ private Evaluator extractInclusiveDeleteExpression(ManifestReader reader) { if (bin.contains(cachedNewManifest) && bin.size() < minManifestsCountToMerge) { // not enough to merge, add all manifest files to the output list outputManifests.addAll(bin); + } else if (bin.size() < minManifestsCountToMerge) { Review comment: However, `bin` is a list, so `contains` is already O(n). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org