manishmalhotrawork commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r346958920
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -205,8 +206,12 @@ protected void add(ManifestFile manifest) {
// the manifest must be rewritten with this update's snapshot ID
try (ManifestReader reader = ManifestReader.read(
ops.io().newInputFile(manifest.path()), ops.current().specsById())) {
- appendManifests.add(ManifestWriter.copyAppendManifest(
- reader, manifestPath(manifestCount.getAndIncrement()), snapshotId(),
appendedManifestsSummary));
+ ManifestFile manifestFile = ManifestWriter.copyAppendManifest(
+ reader, manifestPath(manifestCount.getAndIncrement()), snapshotId(),
appendedManifestsSummary);
+ appendManifests.add(manifestFile);
+ // keep reference to the latest appended manifest, so that we can avoid
merging bins which are
+ // have not crossed the limit of minManifestsCountToMerge
+ cachedNewAppenedManifest = manifestFile;
Review comment:
used `firstAppendedManifest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
