manishmalhotrawork commented on a change in pull request #524: respect
commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#discussion_r333281246
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -595,6 +595,9 @@ private Evaluator
extractInclusiveDeleteExpression(ManifestReader reader) {
if (bin.contains(cachedNewManifest) && bin.size() <
minManifestsCountToMerge) {
// not enough to merge, add all manifest files to the output list
outputManifests.addAll(bin);
+ } else if (bin.size() < minManifestsCountToMerge) {
Review comment:
@aokolnychyi thanks.
> I think this changes the way mergeGroup works and might lead to never
merging certain old manifests.
Are we talking about this case: when old manifest files will not have the
`cachedNewManifest` ( manifest for newly added files ), then with this new
condition it will not merge old manifests till it reaches min.count (default =
100). ?
But wondering, as merge will trigger only when we add new files or manifets,
and manifests for a table should not merge until it reaches min.count or ?
> However, bin is a list, so contains is already O(n).
yeah if we do check whether any of the appendManifests(m) is present in
bin(n) then in worst case it would be 0(n*m).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
