aokolnychyi commented on a change in pull request #588: Add sequential number
prepare for supporting row level delete (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r350083796
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -185,6 +211,15 @@ private void cacheChanges() {
this.cachedDeletes = deletes.build();
}
+ @Override
+ public Long sequenceNumber() {
Review comment:
Hm, does this mean that all existing snapshots written without sequence
numbers will have `sequenceNumber` as 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]