aokolnychyi commented on a change in pull request #588: Add sequential number
prepare for supporting row level delete (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r350939257
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -185,6 +211,15 @@ private void cacheChanges() {
this.cachedDeletes = deletes.build();
}
+ @Override
+ public Long sequenceNumber() {
Review comment:
I think the timestamp-based approach would work for existing snapshots, but
I am not sure how we will propagate this info down to manifests and files. For
example, `ManifestFile` keeps track of the snapshot in which the manifest was
added, but that snapshot can be already expired, so we won't be able to fetch
its metadata. Maybe, defaulting to 0 won't be an issue, let me think more about
this.
@rdblue, any thoughts on keeping backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
