rdblue commented on a change in pull request #628: [WIP] Implement the project and the projectStrict in the transforms URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r350300750
########## File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java ########## @@ -29,14 +29,17 @@ import java.nio.charset.StandardCharsets; import java.util.Set; import java.util.UUID; -import org.apache.iceberg.expressions.BoundLiteralPredicate; +import java.util.stream.Collectors; import org.apache.iceberg.expressions.BoundPredicate; -import org.apache.iceberg.expressions.BoundUnaryPredicate; import org.apache.iceberg.expressions.Expressions; import org.apache.iceberg.expressions.UnboundPredicate; import org.apache.iceberg.types.Type; import org.apache.iceberg.types.Types; +import static org.apache.iceberg.expressions.Expression.Operation.EQ; +import static org.apache.iceberg.expressions.Expression.Operation.IN; +import static org.apache.iceberg.expressions.Expression.Operation.NOT_EQ; +import static org.apache.iceberg.expressions.Expression.Operation.NOT_IN; Review comment: I think the preferred style is to use `Operation.EQ` inline instead of using static imports. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
