rdblue commented on a change in pull request #628: [WIP] Implement the project
and the projectStrict in the transforms
URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r350306115
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Dates.java
##########
@@ -75,6 +80,10 @@ public Type getResultType(Type sourceType) {
return Expressions.predicate(pred.op(), fieldName);
} else if (pred.isLiteralPredicate()) {
return ProjectionUtil.truncateInteger(fieldName,
pred.asLiteralPredicate(), this);
+ } else if (pred.isSetPredicate() && pred.op() == IN) {
Review comment:
This looks the same as the `Bucket` implementation. Can we refactor this
code to use a common method, like the `ProjectionUtil.truncateInteger` used
above? How about `ProjectionUtil.transformSet(String, BoundSetPredicate,
Transform)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
