rdblue commented on a change in pull request #671: Add case insensitive support
to CachingCatalog
URL: https://github.com/apache/incubator-iceberg/pull/671#discussion_r350311990
##########
File path: api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java
##########
@@ -77,6 +77,14 @@ public String name() {
return name;
}
+ public TableIdentifier toLowerCase() {
+ String[] newLevels = Arrays.stream(namespace().levels())
+ .map(String::toLowerCase)
Review comment:
Actually, I think this is correct using the default locale.
We usually pass `Locale.ROOT` to avoid the [Turkish locale
problem](http://mattryall.net/blog/2009/02/the-infamous-turkish-locale-bug) for
strings that are known to be English, typically constants. But table names
should be handled in the environment's locale because they are likely to be in
the locale's language.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
