rdblue commented on a change in pull request #671: Add case insensitive support
to CachingCatalog
URL: https://github.com/apache/incubator-iceberg/pull/671#discussion_r350313612
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -33,17 +33,31 @@
public class CachingCatalog implements Catalog {
public static Catalog wrap(Catalog catalog) {
- return new CachingCatalog(catalog);
+ return wrap(catalog, true);
+ }
+
+ public static Catalog wrap(Catalog catalog, Boolean caseSensitive) {
+ return new CachingCatalog(catalog, caseSensitive);
}
private final Cache<TableIdentifier, Table> tableCache =
Caffeine.newBuilder()
.softValues()
.expireAfterAccess(1, TimeUnit.MINUTES)
.build();
private final Catalog catalog;
+ private final Boolean caseSensitive;
- private CachingCatalog(Catalog catalog) {
+ private CachingCatalog(Catalog catalog, Boolean caseSensitive) {
this.catalog = catalog;
+ this.caseSensitive = caseSensitive;
+ }
+
+ private TableIdentifier formatIdentifier(TableIdentifier tableIdentifier) {
Review comment:
I don't think that "format" is the right verb. How about "canonicalize"? I
know that sounds more like jargon, but the method is really converting to a
canonical version, not formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
