rdblue commented on a change in pull request #600: Implement in and notIn in
multiple visitors
URL: https://github.com/apache/incubator-iceberg/pull/600#discussion_r350319768
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##########
@@ -59,6 +59,10 @@ public R or(R leftResult, R rightResult) {
}
public abstract static class BoundExpressionVisitor<R> extends
ExpressionVisitor<R> {
+ protected <T> Literal<T> toLiteral(T val) {
+ return Literals.from(val);
Review comment:
I don't see value in adding this method. Callers can use `Literals.from`
directly, but the visitors should not even be converting values to literals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
