rdblue commented on a change in pull request #600: Implement in and notIn in
multiple visitors
URL: https://github.com/apache/incubator-iceberg/pull/600#discussion_r350322197
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -269,11 +269,16 @@ public Boolean or(Boolean leftResult, Boolean
rightResult) {
@Override
public <T> Boolean in(BoundReference<T> ref, Set<T> literalSet) {
- return ROWS_MIGHT_MATCH;
+ // in(col, {X, Y}) => eq(col, x) OR eq(col, x)
+ if (literalSet.stream().anyMatch(v -> eq(ref, toLiteral(v)))) {
+ return ROWS_MIGHT_MATCH;
+ }
+ return ROWS_CANNOT_MATCH;
}
@Override
public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
+ // notIn(col, {X, Y}) => notEq(col, x) AND notEq(col, x)
Review comment:
This comment doesn't really make sense, since this doesn't delegate to
`notEq`. Instead, can you copy and update the comment in `notEq`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
