xabriel commented on a change in pull request #315: [WIP] Incremental processing prototype URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r353443961
########## File path: api/src/main/java/org/apache/iceberg/Table.java ########## @@ -44,6 +44,15 @@ */ TableScan newScan(); + + /** + * @param fromSnapshotId - the last snapshot id read by the user, exclusive + * @param toSnapshotId - read incremental data upto this snapshot id + * @return a table scan which can read incremental data from {@param fromSnapshotId} + * exclusive and up to {@toSnapshotId} inclusive + */ + TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId); Review comment: +1 to also have `Table#newIncrementalScan(long fromSnapshotId)` that would read till current snapshot. Regarding method name, can we consider naming them `newDeltaScan` instead? As in, the delta between two snapshots? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org