xabriel commented on a change in pull request #315: [WIP] Incremental
processing prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r354488715
##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -44,6 +44,15 @@
*/
TableScan newScan();
+
+ /**
+ * @param fromSnapshotId - the last snapshot id read by the user, exclusive
+ * @param toSnapshotId - read incremental data upto this snapshot id
+ * @return a table scan which can read incremental data from {@param
fromSnapshotId}
+ * exclusive and up to {@toSnapshotId} inclusive
+ */
+ TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId);
Review comment:
Agreed. `appendsBetween` works, and since it is clear from the name that
only appends are to be returned, I don't think you'd need to throw if you find
overwrites or deletes, you could ignore.
I think we would need `appendsAfter(long fromSnapshotId)` as well, for the
case that would read till current snapshot?
Side note: `deletesBetween` and `overwritesBetween` APIs would be nice as
well in the future. We could help with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
