rdblue commented on a change in pull request #600: Implement in and notIn in
multiple visitors
URL: https://github.com/apache/incubator-iceberg/pull/600#discussion_r355149691
##########
File path:
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
##########
@@ -347,4 +349,52 @@ public void testStringStartsWith() {
shouldRead = ManifestEvaluator.forRowFilter(startsWith("some_nulls", "1"),
SPEC, false).eval(FILE);
Assert.assertFalse("Should skip: range doesn't match", shouldRead);
}
+
+ @Test
+ public void testIntegerIn() {
+ boolean shouldRead = ManifestEvaluator.forRowFilter(in("id", 5, 6), SPEC,
true).eval(FILE);
+ Assert.assertFalse("Should not read: id below lower bound (5 < 30, 6 <
30)", shouldRead);
+
+ shouldRead = ManifestEvaluator.forRowFilter(in("id", 28, 29), SPEC,
true).eval(FILE);
+ Assert.assertFalse("Should not read: id below lower bound (28 < 30, 29 <
30)", shouldRead);
+
+ shouldRead = ManifestEvaluator.forRowFilter(in("id", 30, 31), SPEC,
true).eval(FILE);
Review comment:
I think this test case should be `in("id", 29, 30)` to test the case where
only one value is equal to or greater than the lower bound.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
