rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r358524818
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -104,7 +104,7 @@ public DataSourceReader createReader(StructType
readSchema, DataSourceOptions op
validateWriteSchema(table.schema(), dsSchema, checkNullability(options));
validatePartitionTransforms(table.spec());
String appId = lazySparkSession().sparkContext().applicationId();
- String wapId = lazySparkSession().conf().get("spark.wap.id", null);
+ String wapId =
options.get("write-wap-id").orElse(lazySparkSession().conf().get("spark.wap.id",
null));
Review comment:
How about "wap-id"? The "write" context doesn't add much clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
