rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r360559736
##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -206,6 +206,12 @@ default AppendFiles newFastAppend() {
*/
Rollback rollback();
Review comment:
Yes, something like that. We might want to deprecate the `rollback` API and
just have one for managing snapshots that can do different tasks:
```java
table.manageSnapshots()
.cherrypick(id1)
.cherrypick(id2)
.commit()
```
```java
table.manageSnapshots()
.fastForwardCurrentTo(id)
.commit()
```
```java
table.manageSnapshots()
.resetCurrentTo(id)
.commit()
```
I originally thought we may want to make it API compatible with `rollback`
but `manageSnapshots().toSnapshotId(id)` doesn't make much sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
