rdblue commented on a change in pull request #497: Support retaining last N
snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r361757262
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -55,6 +55,15 @@
*/
ExpireSnapshots expireOlderThan(long timestampMillis);
+ /**
+ * Retains at least last N snapshots and expires all snapshots older than
the given timestamp
+ * in {@link #expireOlderThan(long)}.
Review comment:
I added this to the docs:
> This may keep more than {@code numSnapshot} ancestors if snapshots are
added concurrently. This may keep less than {@numSnapshot} ancestors if the
current table state does not have that many.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
