rdblue commented on a change in pull request #497: Support retaining last N
snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r361757410
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -55,6 +55,15 @@
*/
ExpireSnapshots expireOlderThan(long timestampMillis);
+ /**
+ * Retains at least last N snapshots and expires all snapshots older than
the given timestamp
Review comment:
I documented the behavior with this, which I think covers the case you're
talking about:
> If a snapshot would be expired becuase it is older than the expiration
timestamp, but is one of the numSnapshot most recent ancestors of the current
state, it will be retained. This will not cause snapshots explicitly identified
by id from expiring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
