aokolnychyi commented on a change in pull request #675: Inherit snapshot ids
for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r364319551
##########
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##########
@@ -179,10 +180,14 @@ public void testManifestMergeMinCount() throws
IOException {
Assert.assertEquals("Should contain 2 merged manifest for first write",
2, readMetadata().currentSnapshot().manifests().size());
+ ManifestFile manifest4 = writeManifestWithName("FILE_A", FILE_A);
+ ManifestFile manifest5 = writeManifestWithName("FILE_C", FILE_C);
+ ManifestFile manifest6 = writeManifestWithName("FILE_D", FILE_D);
+
table.newAppend()
- .appendManifest(manifest)
- .appendManifest(manifest2)
- .appendManifest(manifest3)
+ .appendManifest(manifest4)
Review comment:
This change is needed because some of the manifests will be merged during
the previous append and they will be deleted automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
