aokolnychyi commented on a change in pull request #675: Inherit snapshot ids
for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r371887951
##########
File path: core/src/test/java/org/apache/iceberg/TestRewriteManifests.java
##########
@@ -151,7 +232,7 @@ public void testReplaceManifestsWithFilter() throws
IOException {
// get the file order correct
List<DataFile> files;
List<Long> ids;
- try (ManifestReader reader =
ManifestReader.read(localInput(manifests.get(0).path()))) {
+ try (ManifestReader reader = ManifestReader.read(manifests.get(0),
table.io(), null)) {
Review comment:
Maybe, we can overload this method to avoid passing null as a spec map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
