prodeezy commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r367642262
##########
File path: api/src/main/java/org/apache/iceberg/ManageSnapshots.java
##########
@@ -48,6 +58,7 @@
* @return this for method chaining
* @throws IllegalArgumentException If the table has no old snapshot before
the given timestamp
*/
- Rollback toSnapshotAtTime(long timestampMillis);
+ ManageSnapshots rollbackAtTime(long timestampMillis);
Review comment:
Current behavior is: As per your example A, B, C, B .. if i rollback to a
time that C was current (as in rollback to `C.timestampMillis()` ) then B
would be the latest snapshot that is older than that timestamp.
I like this approach coz it protects against rounding off errors and is
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
