prodeezy commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r367677522
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -589,4 +603,20 @@ private static PartitionSpec freshSpec(int specId, Schema
schema, PartitionSpec
}
return builder.build();
}
+
+ private static String publishedWapId(Snapshot snapshot) {
Review comment:
these two methods are creating an index to lookup snapshots by published
wap.ids ..to protect from duplicates. Similar to what `indexSnapshots()` does.
It only reads existing snapshot summaries. The metadata creation itself is
fully delegated to `MergingSnapshotProducer` .. do you think this can be
achieved differently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
