rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r368051340
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -589,4 +603,20 @@ private static PartitionSpec freshSpec(int specId, Schema
schema, PartitionSpec
}
return builder.build();
}
+
+ private static String publishedWapId(Snapshot snapshot) {
Review comment:
Yeah, I think these should be in a utility class for WAP pattern to avoid
having this class do too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
