rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot 
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r368056349
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
 ##########
 @@ -55,4 +56,28 @@ private SnapshotUtil() {
     }
     return ancestorIds;
   }
+
+  public static boolean isCurrentAncestor(TableMetadata tableMeta, long 
snapshotId) {
 
 Review comment:
   The other methods in `SnapshotUtil` use the public API, which does not 
include `TableMetadata`. Can we update this to use `Table` instead of 
`TableMetadata` as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to