aokolnychyi commented on a change in pull request #786: replace SparkDataFile 
with DataFile
URL: https://github.com/apache/incubator-iceberg/pull/786#discussion_r377404989
 
 

 ##########
 File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala
 ##########
 @@ -492,10 +454,11 @@ object SparkTableUtil {
     val conf = spark.sessionState.newHadoopConf()
     val metricsConfig = MetricsConfig.fromProperties(targetTable.properties)
 
-    val files = listPartition(Map.empty, sourceTable.location.toString, 
format.get, conf, metricsConfig)
+    val files = listPartition(Map.empty, sourceTable.location.toString, 
format.get, conf, metricsConfig,
 
 Review comment:
   What about this?
   
   ```
   val partition = Map.empty[String, String]
   val spec = PartitionSpec.unpartitioned()
   val conf = spark.sessionState.newHadoopConf()
   val metricsConfig = MetricsConfig.fromProperties(targetTable.properties)
   
   val files = listPartition(partition, sourceTable.location.toString, 
format.get, spec, conf, metricsConfig)
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to