chenjunjiedada commented on a change in pull request #786: replace
SparkDataFile with DataFile
URL: https://github.com/apache/incubator-iceberg/pull/786#discussion_r377411005
##########
File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala
##########
@@ -174,22 +175,23 @@ object SparkTableUtil {
* @param format partition format, avro or parquet
* @param conf a Hadoop conf
* @param metricsConfig a metrics conf
- * @return a seq of [[SparkDataFile]]
+ * @return a seq of [[DataFile]]
*/
def listPartition(
partition: Map[String, String],
uri: String,
format: String,
conf: Configuration = new Configuration(),
- metricsConfig: MetricsConfig = MetricsConfig.getDefault):
Seq[SparkDataFile] = {
+ metricsConfig: MetricsConfig = MetricsConfig.getDefault,
+ spec: PartitionSpec): Seq[DataFile] = {
Review comment:
Make sense, will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
