rdblue commented on a change in pull request #828: iceberg-spark changes for
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/828#discussion_r389129101
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -158,11 +129,19 @@
} else {
this.localityPreferred = false;
}
-
this.schema = table.schema();
this.io = io;
this.encryptionManager = encryptionManager;
this.caseSensitive = caseSensitive;
+ // override logic to check when batched reads is enabled by turning off
batched reads
+ boolean disableBatchedReads =
+
options.get("iceberg.read.disablevectorizedreads").map(Boolean::parseBoolean).orElse(false);
Review comment:
Options that enable/disable should use "enabled". That avoids users needing
to think about whether options enable or disable - true always enables and
false always disables.
I recommend using `iceberg.read.parquet-vectorization.enabled`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
