rdblue commented on a change in pull request #828: iceberg-spark changes for
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/828#discussion_r389131815
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -188,6 +167,27 @@ public StructType readSchema() {
return lazyType();
}
+ /**
+ * This is called in the Spark Driver when data is to be materialized into
[ColumnarBatch]s
+ */
+ @Override
+ public List<InputPartition<ColumnarBatch>> planBatchInputPartitions() {
+ Preconditions.checkState(enableBatchRead != null && enableBatchRead,
"Batched reads not enabled");
Review comment:
Why would `enableBatchRead` be null? Why not use a `boolean` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
