shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r394077241
########## File path: site/docs/spec.md ########## @@ -483,25 +483,25 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo **Data Type Mappings** -| Type | ORC type | Notes | -|--------------------|-------------|-----------------------------------------------------------------------------------------| -| **`boolean`** | `boolean` | | -| **`int`** | `int` | ORC `tinyint` and `smallint` would also map to **`int`**. | -| **`long`** | `long` | | -| **`float`** | `float` | | -| **`double`** | `double` | | -| **`decimal(P,S)`** | `decimal` | | -| **`date`** | `date` | | -| **`time`** | `int` | Stores microseconds from midnight. | -| **`timestamp`** | `timestamp` | | -| **`timestamptz`** | `struct` | We should add this to ORC’s type model (ORC-294). | -| **`string`** | `string` | ORC `varchar` and `char` would also map to **`string`**. | -| **`uuid`** | `binary` | | -| **`fixed(L)`** | `binary` | The length would not be checked by the ORC reader and should be checked by the adapter. | -| **`binary`** | `binary` | | -| **`struct`** | `struct` | ORC `uniontype` would also map to **`struct`**. | -| **`list`** | `array` | | -| **`map`** | `map` | | +| Type | ORC type | Notes | +|--------------------|---------------------|-----------------------------------------------------------------------------------------| +| **`boolean`** | `boolean` | | +| **`int`** | `int` | ORC `tinyint` and `smallint` would also map to **`int`**. | +| **`long`** | `long` | | +| **`float`** | `float` | | +| **`double`** | `double` | | +| **`decimal(P,S)`** | `decimal` | | +| **`date`** | `date` | | +| **`time`** | `long` | Stores microseconds from midnight. | +| **`timestamp`** | `timestamp` | | +| **`timestamptz`** | `timestamp_instant` | | +| **`string`** | `string` | ORC `varchar` and `char` would also map to **`string`**. | +| **`uuid`** | `binary` | | +| **`fixed(L)`** | `binary` | The length would not be checked by the ORC reader and should be checked by the adapter. | +| **`binary`** | `binary` | | +| **`struct`** | `struct` | ORC `uniontype` would also map to **`struct`**. | Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
