rdblue commented on issue #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#issuecomment-600874095 > We now use ZoneId and ZonedDateTime instead of ZoneOffset and OffsetDateTime Avro and Parquet currently return OffsetDateTime and LocalDateTime for timestamptz and timestamp. The values returned for all 3 formats should match so that users can expect consistent classes. So we should either use OffsetDateTime, or change all 3 to use ZonedDateTime. I think we should continue to use OffsetDateTime, but I'm up for hearing why we should use ZonedDateTime. The rationale for OffsetDateTime is that we don't store zone information. All timestamps are converted to an instant that is the same across all zones. We pass that instant back as a UTC value for convenience, but Iceberg doesn't interpret that instant with respect to some zone. Conversions are the responsibility of processing engines, Iceberg just stores values and returns them unmodified.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
