openinx commented on a change in pull request #854: Fix 
ConcateCloseableIterable issue with starting empty iterables
URL: https://github.com/apache/incubator-iceberg/pull/854#discussion_r395140607
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
 ##########
 @@ -130,6 +130,20 @@ public O next() {
       private ConcatCloseableIterator(Iterable<CloseableIterable<E>> inputs) {
         this.iterables = inputs.iterator();
         this.currentIterable = iterables.next();
+        // Exhaust the starting empty iterables.
+        while (Iterables.isEmpty(currentIterable)) {
 
 Review comment:
   +1, Make sense. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to