rdsr commented on a change in pull request #854: Fix ConcateCloseableIterable
issue with starting empty iterables
URL: https://github.com/apache/incubator-iceberg/pull/854#discussion_r397412559
##########
File path: api/src/test/java/org/apache/iceberg/AssertHelpers.java
##########
@@ -68,17 +68,43 @@ public static void assertThrows(String message,
}
}
+ /**
+ * A convenience method to avoid a large number of @Test(expected=...) tests
+ * @param message A String message to describe this assertion
+ * @param expected An Exception class that the Runnable should throw
+ * @param callable A Callable that is expected to throw the exception
+ */
+ public static void assertThrows(String message,
Review comment:
Seems like we could have avoid these methods if we throw
NoSuchElementException with a message. But I guess I'm OK with these as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
