massdosage commented on a change in pull request #843: [WIP] InputFormat support for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/843#discussion_r395781356
########## File path: mr/src/main/java/org/apache/iceberg/mr/IcebergInputFormat.java ########## @@ -0,0 +1,494 @@ +/* Review comment: Can I suggest putting this and the related classes into a `org.apache.iceberg.mr.mapreduce` package? So we can then add the `org.apache.iceberg.mr.mapred` implementation alongside it and the package names match the Hadoop API package names? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
