massdosage commented on a change in pull request #843: [WIP] InputFormat
support for Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/843#discussion_r395780577
##########
File path: build.gradle
##########
@@ -193,6 +193,24 @@ project(':iceberg-hive') {
}
}
+project(':iceberg-mr') {
+ dependencies {
+ compile project(':iceberg-api')
+ compile project(':iceberg-core')
+ compile project(':iceberg-hive')
+ compile project(':iceberg-orc')
+ compile project(':iceberg-parquet')
+
+ compileOnly("org.apache.hadoop:hadoop-client") {
+ exclude group: 'org.apache.avro', module: 'avro'
+ }
+
+ testCompile project(path: ':iceberg-hive', configuration: 'testArtifacts')
Review comment:
I can see a future where we have Hive SerDes and StorageHandlers in the
`hive` subproject which in turn will need to depend on the input format(s) here
so we need to avoid a circular dependency right? In our
[InputFormat](https://github.com/ExpediaGroup/hiveberg/blob/master/src/main/java/com/expediagroup/hiveberg/IcebergInputFormat.java)
up to now we've just use HadoopTables and the JobConf to get everything we
need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
