shawnding commented on a change in pull request #857: [ISSUE #855] Add the Test
Util And ORC Writer for Spark
URL: https://github.com/apache/incubator-iceberg/pull/857#discussion_r399891462
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -269,7 +269,7 @@ private static TypeDescription buildOrcProjection(Integer
fieldId, Type type, bo
break;
case MAP:
Types.MapType map = (Types.MapType) type;
- TypeDescription keyType = buildOrcProjection(map.keyId(),
map.keyType(), true, mapping);
Review comment:
While a `MapType ` column is optional if insert an empty map like `null`,
the `key` and `value` both are `null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
