rdblue commented on issue #857: [ISSUE #855] Add the Test Util And ORC Writer for Spark URL: https://github.com/apache/incubator-iceberg/pull/857#issuecomment-606900506 This looks good to me, except for two things: 1. Map keys are always required if the map is projected, so I'm not sure the map change is correct. 2. I think it would make more sense to add nested tests later. The majority of these changes are test changes to add a map. I don't think the amount of change here is worth such a narrow set of cases -- one string map with the same key/values each time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
